Skip to content

Adds ruff config#29

Merged
divyashreepathihalli merged 3 commits intomainfrom
format
Feb 18, 2026
Merged

Adds ruff config#29
divyashreepathihalli merged 3 commits intomainfrom
format

Conversation

@JyotinderSingh
Copy link
Collaborator

@JyotinderSingh JyotinderSingh commented Feb 18, 2026 •
edited
Loading

Adds the following ruff config, and sets up GitHub Actions + pre-commit hooks

[tool.ruff]
indent-width = 2
line-length = 80

[tool.ruff.lint]
select = ["B", "E", "F", "N", "PYI", "T20", "TID", "SIM", "W", "I", "NPY"]
ignore = ["E501"]

@gemini-code-assist
Copy link
Contributor

gemini-code-assist bot commented Feb 18, 2026

Summary of Changes

Hello @JyotinderSingh, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the project's code quality and developer experience by introducing Ruff for linting and formatting. It establishes a robust pre-commit hook system to automate code style checks and provides clear documentation for setting up the development environment, ensuring all contributions adhere to defined standards.

Highlights

  • Ruff Integration: Integrated Ruff linter and formatter into the project using pre-commit hooks to ensure consistent code style and quality.
  • Development Workflow: Updated the README.md with a new "Development Setup" section, guiding contributors on installing development dependencies and pre-commit hooks.
  • Dependency Management: Added absl-py as a core dependency and included pre-commit and ruff in the dev dependency group within pyproject.toml.
  • Ruff Configuration: Configured Ruff settings in pyproject.toml, specifying indent-width, line-length, selected lint rules, and ignored rules.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog
  • .pre-commit-config.yaml
    • Added a new file to configure pre-commit hooks.
    • Included ruff and ruff-format hooks from astral-sh/ruff-pre-commit.
  • README.md
    • Inserted a new "Development Setup" section.
    • Provided instructions for installing dev dependencies and pre-commit hooks.
    • Explained how to manually run pre-commit checks.
  • pyproject.toml
    • Added absl-py to the main dependencies list.
    • Introduced a new dev extra dependency group including pre-commit and ruff.
    • Added a [tool.ruff] section to configure indent-width, line-length, select lint rules, and ignore rules.
Ignored Files
  • Ignored by pattern: .github/workflows/** (1)
    • .github/workflows/lint.yaml
Activity
  • No human activity (comments, reviews, etc.) has been recorded on this pull request yet.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist[bot]
gemini-code-assist bot reviewed Feb 18, 2026
View reviewed changes
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces ruff for linting and formatting, along with pre-commit hooks to enforce it. The changes also update the README with development setup instructions. My review focuses on ensuring the new configuration is correct and consistent with the project's standards. I've noted a likely invalid version in the pre-commit configuration that will prevent it from working, a dependency that might be misplaced, and an indentation setting that is inconsistent with the project's style guide and Python conventions.

@JyotinderSingh JyotinderSingh marked this pull request as ready for review February 18, 2026 19:34
@divyashreepathihalli divyashreepathihalli merged commit 516107f into main Feb 18, 2026
2 checks passed
@JyotinderSingh JyotinderSingh deleted the format branch February 19, 2026 04:03
@divyashreepathihalli divyashreepathihalli mentioned this pull request Feb 19, 2026
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@divyashreepathihalli divyashreepathihalli divyashreepathihalli approved these changes

@jeffcarp jeffcarp Awaiting requested review from jeffcarp

+1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@JyotinderSingh @divyashreepathihalli